-
Notifications
You must be signed in to change notification settings - Fork 227
Fix docs about the A param of KSN config #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dwdougherty sorry for the mistake! Pls review |
@dwdougherty actually, this became a point of dialogue if these new KSN even types should be enabled by default for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll hold until you tell me to let it fly.
Final fix is comitted. The KSN feature PR that necessitated the changes is finalized and merged in unstable. |
Hi @minchopaskal. Thanks for the update. The keyspace notifications page has been moved. It now lives here: https://redis.io/docs/latest/develop/pubsub/keyspace-notifications/ So, you'll need to refresh your fork and edit your PR. Apologies. |
1e32f62
to
a2db6db
Compare
Tnx for the update @dwdougherty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @minchopaskal! LGTM.
In recent PR about adding docs for new KSN types I forgot to add some docs, so this PR fixes that